Editor Tools Programmer Project (split)

Kalium · Post by **Kalium** » Tue Apr 06, 2004 8:33 am

These two lines look to be the most likely culprits:

bi.biBitCount = 32;
    fi.getframe = AVIStreamGetFrameOpen(fi.video, &bi);

Maybe it's that the bitcount is being statically set instead of determined by a call?

AbsoluteDestiny · Post by **AbsoluteDestiny** » Tue Apr 06, 2004 9:03 am

It's specified in AVISTREAMINFO but BITMAPINFOHEADER should be able to detect the bitcount.

I figured AVISTREAMINFO would be for premiere's benefit and BITMAPINFOHEADER is for the plugin to workout what to do with the info it's getting.

I'm not really sure - I'm not a programmer so this is all new to me

BogoSort · Post by **BogoSort** » Tue Apr 06, 2004 9:15 am

Can I get added to this project too?

username: bogosort
userid: 1006795

BogoSort · Post by **BogoSort** » Tue Apr 06, 2004 9:47 am

Well the way that it's written it sets biBitCount to 32. Then it tries to open it and produce an output in 32 bits, which is successful(since I believe that windows does the conversion), so then it sets the bpp to be 32 and goes on its merry way. It's not actually doing any detection on the code.

AbsoluteDestiny · Post by **AbsoluteDestiny** » Tue Apr 06, 2004 9:58 am

OK so the question is why can't we see anything when we use 24bit rgb source from avisynth?

Maybe it's something to do with the bitpacking... I'll have to have a closer look at that.

trythil · Post by **trythil** » Tue Apr 06, 2004 11:36 am

AbsoluteDestiny wrote:OK, here's something.

The Premiere Pro code works just fine with premiere 6 and hopefully too with premiere 5 (I can test that later) which means that we can have one version. I'll check cvs in a bit to see what version we have up there.

The Premiere Pro AVISynth plugin sources don't exist in a stable state in the CVS tree. SourceForge's CVS server has been bugging out on me, so I've been unable to successfully commit the stuff all morning.

Hopefully it will stabilize soon.

AbsoluteDestiny · Post by **AbsoluteDestiny** » Tue Apr 06, 2004 12:21 pm

Yeah, sourceforge has been really slow for me

dwchang · Post by **dwchang** » Tue Apr 06, 2004 12:26 pm

BogoSort wrote:Well the way that it's written it sets biBitCount to 32. Then it tries to open it and produce an output in 32 bits, which is successful(since I believe that windows does the conversion), so then it sets the bpp to be 32 and goes on its merry way. It's not actually doing any detection on the code.

Maybe I'm being stupid (probably since I haven't looked at this code), but if you send a 24-bit string and it encodes it to 32, is it as simple as destroyng the top 8 bits to bring it back to 24-bits? I don't know if by "conversion" it just appends 0's to the end to make it a compliant 32-bit output for that variable.

I imagine I'm totally reading this the wrong way and just talked non-sense :-/.

AbsoluteDestiny · Post by **AbsoluteDestiny** » Tue Apr 06, 2004 12:29 pm

Stop thinking in terms of code and think in terms of video and it will make sense. There are samples for R G and B (24 bits) but no samples for the alpha channel so those are all 0's

BogoSort · Post by **BogoSort** » Tue Apr 06, 2004 12:44 pm

AbsoluteDestiny wrote:Stop thinking in terms of code and think in terms of video and it will make sense. There are samples for R G and B (24 bits) but no samples for the alpha channel so those are all 0's :)

Is it stored as RGBA or ARGB? I could see how the latter would quickly make you unable to see anything by trying to read a 24bit stream as 32 bit. Need to look at the code some more. I'm not too familiar with video code, but this isn't the most well written code to begin with...