Filtering Help

This forum is for questions and discussion of all the aspects of handling your footage. If you have questions about capturing/ripping footage, AviSynth, or compression/encoding/converting, look here.

Filtering Help

Postby Glitzer » Mon Mar 01, 2010 12:46 pm

Hello everybody,
Sorry to bother, but I'm new to the world of amvs and especially new to filtering and 720p. I'm afraid of messing up my video with filters, but I want to get it looking as nice as possible, so I was wondering what kind of filters should I use for 4 of these different videos.


http://img237.imageshack.us/img237/3640 ... hot4gj.jpg

http://img707.imageshack.us/img707/2789 ... hot3xp.jpg

http://img148.imageshack.us/img148/6536 ... hot2lt.jpg

http://img718.imageshack.us/img718/3483 ... shotoy.jpg

I just screenshotted with media player classic so I hope that doesn't hurt the quality. Thank you!
Image ImageImage
User avatar
Glitzer
 
Joined: 28 Jan 2010
Location: Livin' in a van down by the river
Status: Loading ███████████ 99%

Re: Filtering Help

Postby Kariudo » Mon Mar 01, 2010 2:04 pm

I'm not seeing anything obvious that needs to be fixed in any of those screenshots, save for the last one which could use a good sharpening using something like limitedsharpenfaster()

Code Geass looks like it could use some line darkening to me, but that's up to you if you want to do it or not. Something a la fastlinedarken().
ImageImage
Image
User avatar
Kariudo
Twilight prince
 
Joined: 15 Jul 2005
Location: Los taquitos unidos
Status: 1924 bots banned and counting!

Re: Filtering Help

Postby mirkosp » Mon Mar 01, 2010 2:39 pm

Get us pngs, I see some horizontal "lines" and some slight blocking that I'm almost positive are jpg artifacts but I can't be sure, especially for Utawarerumono. One thing I am positive of, though, is that the black lagoon footage needs some cropping. Looks like it needed a 1 or 2 pixel per side crop on 1080p, since now there's a 1 pixel contour that is slightly darker - prolly due to having blended a black pixel and a pixel with actual image together. Oh, and Claymore looks poorly upscaled.
Image
User avatar
mirkosp
MODkip
 
Joined: 24 Apr 2006
Location: Gallarate (VA), Italy
Status: (」・ワ・)」(⊃・ワ・)⊃

Re: Filtering Help

Postby Glitzer » Mon Mar 01, 2010 2:42 pm

Appreciate the feedback!

Hrm, thats odd, I get a script error when I tried to open the Code Geass script I made "there is no function named 'fastlinedarken'". If it comes down to a matter of personal taste, perhaps I'll leave it alone for now.

The Utawarerumono one I think I fixed though.

http://img202.imageshack.us/img202/7238 ... rumono.jpg

with the original: http://img718.imageshack.us/img718/3483 ... shotoy.jpg
Image ImageImage
User avatar
Glitzer
 
Joined: 28 Jan 2010
Location: Livin' in a van down by the river
Status: Loading ███████████ 99%

Re: Filtering Help

Postby Glitzer » Mon Mar 01, 2010 2:44 pm

Crap. I'll get on those pngs right away mirkosp! Man, I was afraid of the Claymore one though. Its one of Funi's infamous upscales. I might have to leave Claymore out of this project...
Image ImageImage
User avatar
Glitzer
 
Joined: 28 Jan 2010
Location: Livin' in a van down by the river
Status: Loading ███████████ 99%

Re: Filtering Help

Postby Glitzer » Mon Mar 01, 2010 3:08 pm

Image ImageImage
User avatar
Glitzer
 
Joined: 28 Jan 2010
Location: Livin' in a van down by the river
Status: Loading ███████████ 99%

Re: Filtering Help

Postby mirkosp » Mon Mar 01, 2010 5:03 pm

They do look better now. Utawarerumono has some noticeable issues with the red chroma. Curiously enough, though, they seem to be just due to the RGB colorspace, as converting the image to YV12 makes it look good. Since I believe your input is already YV12, I'd say place a converttorgb32 into your script to make sure that avisynth handles properly the chroma conversion. Claymore does indeed look like a bad upscale, sharpening wouldn't help much; if dropping it altogether from the sources you're going to use is a feasible option, then do so. Also,I'm still seeing that slight border to be cropped on black lagoon, but good stuff for the rest.
Image
User avatar
mirkosp
MODkip
 
Joined: 24 Apr 2006
Location: Gallarate (VA), Italy
Status: (」・ワ・)」(⊃・ワ・)⊃

Re: Filtering Help

Postby Kariudo » Mon Mar 01, 2010 5:04 pm

copy everything in the code tag, paste into notepad, save as fastlinedarkenMOD.avsi, put into the avisynth plugin folder (/program files/avisynth2.5/plugins/)then you should be able to use it.

Note that you need mt_masktools (you should already have it) and your video needs to be in yv12 colorspace (which you might have to do yourself.)
Try just putting FastLineDarkenMOD() in your script, and if it complains then add converttoyv12() after avisource, directshowsource, ffmpegsource, mpeg2source or whatever source filter you used to import your video

Code: Select all
##############################
# FastLineDarken 1.3x MT MOD #
##############################
#
# Written by Vectrangle
# Didée: - Speed Boost, Updated: 11th May 2007
#
#  * requires mt_masktools v2
#  * requires yv12 input
#
# Usage is FastLineDarkenMOD(strength, luma_cap, threshold, thinning),
#   named parameters are supported eg FastLineDarken(thinning=0)
#
# Note that you must import this avs into your script using import("...\FastLineDarken.avs")
#
# Parameters are:
#  strength (integer)  - Line darkening amount, 0-256. Default 48. Represents the _maximum_ amount
#                        that the luma will be reduced by, weaker lines will be reduced by
#                        proportionately less.
#  luma_cap (integer)  - value from 0 (black) to 255 (white), used to stop the darkening
#                        determination from being 'blinded' by bright pixels, and to stop grey
#                        lines on white backgrounds being darkened. Any pixels brighter than
#                        luma_cap are treated as only being as bright as luma_cap. Lowering
#                        luma_cap tends to reduce line darkening. 255 disables capping. Default 191.
#  threshold (integer) - any pixels that were going to be darkened by an amount less than
#                        threshold will not be touched. setting this to 0 will disable it, setting
#                        it to 4 (default) is recommended, since often a lot of random pixels are
#                        marked for very slight darkening and a threshold of about 4 should fix
#                        them. Note if you set threshold too high, some lines will not be darkened
#  thinning (integer)  - optional line thinning amount, 0-256. Setting this to 0 will disable it,
#                        which is gives a _big_ speed increase. Note that thinning the lines will
#                        inherently darken the remaining pixels in each line a little. Default 24.
#
# Changelog:
#  1.3  - added ability to thin lines, now runs much slower unless thinning=0. Changed the defaults (again)
#  1.2  - huge speed increase using yv12lutxy =)
#       - weird darkening issues gone (they were caused by yv12layer)
#       - show option no longer available due to optimizations. Use subtract() instead
#  1.1  - added luma_cap option
#  1.0  - initial release
#


function FastLineDarkenMOD( clip c, int "strength", int "luma_cap", int "threshold", int "thinning")
{
## parameters ##
str    = string(default(strength, 48) /128.)
lum    = string(default(luma_cap, 191))
thr    = string(default(threshold, 4))
thinning = default(thinning,24)
thn    = string(thinning /16.)

## filtering ##
exin   = c.mt_expand().mt_inpand()
diff    = mt_lutxy(c,exin,yexpr="y "+lum+" < y "+lum+" ? x "+thr+" + > x y "+lum+" < y "+lum+" ? - 0 ? 127 +",uexpr="x",vexpr="x",u=2, v=2)
linemask= mt_lut(diff.mt_inpand(),"x 127 - "+thn+" * 255 +").RemoveGrain(20,-1)
thick    = mt_lutxy(c, exin, yexpr="y "+lum+" < y "+lum+" ? x "+thr+" + > x y "+lum+" < y "+lum+" ? - 0 ? "+str+" * x +",uexpr="x",vexpr="x",u=2, v=2)
thin    = mt_lutxy(c.mt_expand(),diff,yexpr="x y 127 - "+str+" 1 + * +",u=2, v=2)

return (thinning == 0) ? thick : mt_merge(thin,thick,linemask,y=3,u=2,v=2)
}
ImageImage
Image
User avatar
Kariudo
Twilight prince
 
Joined: 15 Jul 2005
Location: Los taquitos unidos
Status: 1924 bots banned and counting!

Re: Filtering Help

Postby mirkosp » Mon Mar 01, 2010 5:14 pm

I think he's dealing with blu-rays directly, so they should already be yv12.
Image
User avatar
mirkosp
MODkip
 
Joined: 24 Apr 2006
Location: Gallarate (VA), Italy
Status: (」・ワ・)」(⊃・ワ・)⊃

Re: Filtering Help

Postby Glitzer » Mon Mar 01, 2010 6:00 pm

Yeah, in Virtual Dub the file information says "Internal DIB decoder YV12"

Ok so I did something wrong... very wrong. I followed your directions Kariudo and somehow all the colors are in chaos.

http://img37.imageshack.us/img37/2826/blaugha.png

http://img35.imageshack.us/img35/6632/blaugh2.png

http://img5.imageshack.us/img5/5373/blaugh3.png

In fact, every script I open up even if there are no filters looks like that. How bizarre.

Oh, I was also wondering if I could edit with the raw script then edit the script later and have it update inside premiere. Like if after I finish my or what not then add the filters? My laptop is a slowbie and the filters put extra strain on it.

Hey I really appreciate all the help Kariudo and mirkosp. This was my first attempt at filtering and after marathoning all the guides, I thought it was going to be a nightmare. You guys make it nice and simple though.
Image ImageImage
User avatar
Glitzer
 
Joined: 28 Jan 2010
Location: Livin' in a van down by the river
Status: Loading ███████████ 99%

Re: Filtering Help

Postby Scintilla » Mon Mar 01, 2010 9:17 pm

Glitzer wrote:Ok so I did something wrong... very wrong. I followed your directions Kariudo and somehow all the colors are in chaos.

http://img37.imageshack.us/img37/2826/blaugha.png

http://img35.imageshack.us/img35/6632/blaugh2.png

http://img5.imageshack.us/img5/5373/blaugh3.png

In fact, every script I open up even if there are no filters looks like that. How bizarre.

Did you add any new plugins to your plugins directory to get FLD to work, or did you just add the FLD script itself? If you added new plugins, then I'd suggest removing them one by one until you find the one that breaks the colors.
I know I've seen this kind of effect before, but I can't remember what caused it...

Glitzer wrote:Oh, I was also wondering if I could edit with the raw script then edit the script later and have it update inside premiere. Like if after I finish my or what not then add the filters? My laptop is a slowbie and the filters put extra strain on it.

Yes. Just comment the filter lines out until you're ready for final export; I do this all the time myself. In fact, this is specifically suggested in the A/V tech guide.
ImageImage
:pizza: :pizza: Image :pizza: :pizza:
User avatar
Scintilla
(for EXTREME)
 
Joined: 31 Mar 2003
Location: New Jersey
Status: Quo

Re: Filtering Help

Postby mirkosp » Tue Mar 02, 2010 2:09 am

Kariudo's script is wrong, here's the fixed fastlinedarkenmod script:
Code: Select all
#############################
# FastLineDarken 1.3 MT MOD #
#############################
#
# Written by Vectrangle, last update 12 Sept 04
#
#  * requires masktools 1.5.1 -- http://jourdan.madism.org/~manao/
#  * requires yv12 input
#
# Usage is FastLineDarken(strength, luma_cap, threshold, thinning),
#   named parameters are supported eg FastLineDarken(thinning=0)
#
# Note that you must import this avs into your script using import("...\FastLineDarken.avs")
#
# Parameters are:
#  strength (integer)  - Line darkening amount, 0-256. Default 48. Represents the _maximum_ amount
#                        that the luma will be reduced by, weaker lines will be reduced by
#                        proportionately less.
#  luma_cap (integer)  - value from 0 (black) to 255 (white), used to stop the darkening
#                        determination from being 'blinded' by bright pixels, and to stop grey
#                        lines on white backgrounds being darkened. Any pixels brighter than
#                        luma_cap are treated as only being as bright as luma_cap. Lowering
#                        luma_cap tends to reduce line darkening. 255 disables capping. Default 191.
#  threshold (integer) - any pixels that were going to be darkened by an amount less than
#                        threshold will not be touched. setting this to 0 will disable it, setting
#                        it to 4 (default) is recommended, since often a lot of random pixels are
#                        marked for very slight darkening and a threshold of about 4 should fix
#                        them. Note if you set threshold too high, some lines will not be darkened
#  thinning (integer)  - optional line thinning amount, 0-256. Setting this to 0 will disable it,
#                        which is gives a _big_ speed increase. Note that thinning the lines will
#                        inherently darken the remaining pixels in each line a little. Default 24.
#
# Changelog:
#  1.3  - added ability to thin lines, now runs much slower unless thinning=0. Changed the defaults (again)
#  1.2  - huge speed increase using yv12lutxy =)
#       - weird darkening issues gone (they were caused by yv12layer)
#       - show option no longer available due to optimizations. Use subtract() instead
#  1.1  - added luma_cap option
#  1.0  - initial release
#


function FastLineDarkenMOD( clip c, int "strength", int "luma_cap", int "threshold", int "thinning")
{
## parameters ##
str    = string(default(strength, 48) /128.)
lum    = string(default(luma_cap, 191))
thr    = string(default(threshold, 4))
thinning = default(thinning,24)
thn    = string(thinning /16.)

## filtering ##
exin   = c.mt_expand().mt_inpand()
diff    = mt_lutxy(c,exin,yexpr="y "+lum+" < y "+lum+" ? x "+thr+" + > x y "+lum+" < y "+lum+" ? - 0 ? 127 +",uexpr="x",vexpr="x",u=2, v=2)
linemask= mt_lut(diff.mt_inpand(),"x 127 - "+thn+" * 255 +").mt_convolution("1 1 1","1 1 1",y=3,u=0,v=0)
thick    = mt_lutxy(c, exin, yexpr="y "+lum+" < y "+lum+" ? x "+thr+" + > x y "+lum+" < y "+lum+" ? - 0 ? "+str+" * x +",uexpr="x",vexpr="x",u=2, v=2)
thin    = mt_lutxy(c.mt_expand(U=2,V=2),diff,yexpr="x y 127 - "+str+" 1 + * +",u=2, v=2)

return (thinning == 0) ? thick : mt_merge(thin,thick,linemask,y=3,u=2,v=2)
}


As you can see, it missed the U=2,V=2 inside the mt_expand() which made it fail with the chroma. I think that calling it with thinning=0 would have worked fine, though, but if you wanted that slight thinning it comes with then yeah, updating to this one is the solution.

EDIT: Or actually, it seems that Kariudo's version is more recent... But I do remember that the lack of the U=2,V=2 gave chroma related bugs.Try to edited that into Kariudo's script, maybe. An alternative solution could also be calling it like so:
Code: Select all
mergeluma(fastlinedarkenMOD)

That way it won't mess with the chroma.
Image
User avatar
mirkosp
MODkip
 
Joined: 24 Apr 2006
Location: Gallarate (VA), Italy
Status: (」・ワ・)」(⊃・ワ・)⊃


Return to Footage Help

Who is online

Users browsing this forum: No registered users and 0 guests